Issue Details

Number

23119

Title

test: replace bare asserts with assertion helpers (assert_equal() etc.)

Description

#23117 replaced asserts with the test framework's internal helpers (see https://github.com/bitcoin/bitcoin/blob/dccf3d25f9e78909eb7b3143e89a7c87fac25ab5/test/functional/test_framework/util.py#L47-L59) for a single test, in order to see the expected and failed values if such an assertion fails. The same should be done for all the remaining tests. Potential candidates can be found via ``` $ cd ./test/functional $ git grep assert.*== $ git grep "assert.*<=" $ git grep "assert.*>=" $ git grep "assert.*<" $ git grep "assert.*>" ``` #### Useful skills: basic Python3 knowledge #### Want to work on this issue? For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.

URL

https://github.com/bitcoin/bitcoin/issue/23119

Closed by

#28528

Notes

Attention of

Kill Factor (1-10)

Save

Back to List