Issue Details

Number

23279

Title

Add unit tests for Taproot code in src/script/interpreter.cpp

Description

The Taproot code in `src/script/interpreter.cpp` is covered by our functional tests (`test/functional/feature_taproot.py` and `test/functional/wallet_taproot.py`), but we don't have any unit test coverage for this code. Unit test coverage for `src/script/interpreter.cpp` can be found here: * https://marcofalke.github.io/btc_cov/test_bitcoin.coverage/src/script/interpreter.cpp.gcov.html These functions in `src/script/interpreter.cpp` are currently not covered by our unit tests: * `EvalChecksigTapscript` * `HandleMissingData` * `SignatureHashSchnorr` * `GenericTransactionSignatureChecker<T>::VerifySchnorrSignature` * `GenericTransactionSignatureChecker<T>::CheckSchnorrSignature` * `ComputeTaprootMerkleRoot` * `SigVersion::TAPSCRIPT` code paths in `ExecuteWitnessScript` * Taproot code paths in `VerifyWitnessProgram` It would be nice to have C++ unit tests covering this code in addition to the Python functional tests.

URL

https://github.com/bitcoin/bitcoin/issue/23279

Closed by

Notes

Attention of

Kill Factor (1-10)

Save

Back to List