Issue Details

Number

8798

Title

whiteconnections should be re-added

Description

The `whiteconnections` option was added in 0.12 but later removed in #6374 because it was viewed as being redundant. While whitelisted connections can no longer be _evicted_ as of that PR, `whiteconnections` is still useful because it allows for _new_ connections. For example, you could have a full node that you use as a gateway for several of your lightweight nodes, and in this case it may be impossible for you to connect to your gateway due to insufficient connection slots. whiteconnections solved this, but it is now removed. Here's a real-world complaint about this issue: https://www.reddit.com/r/Bitcoin/comments/540hoj/can_whitelistnetmask_free_up_a_connection/ Perhaps it would be more elegant to detect when a whitelisted peer is trying to connect when we have no more connection slots, and trigger the eviction of a non-whitelisted inbound peer in this case. But it's probably easier to just re-add `whiteconnections`.

URL

https://github.com/bitcoin/bitcoin/issue/8798

Closed by

#27600

Notes This is a good open question: Should white* inbounds ALWAYS be accepted and added? Or is the maxconnections limit MORE important? Could a white* inbound evict another peer if we are at max? Or does that open up attack vectors.

Attention of

Kill Factor (1-10)

Save

Back to List