Issue Details

Number

29410

Title

p2p: lingering entries in `mapBlockSource`

Description

Opening an issue per https://github.com/bitcoin/bitcoin/pull/28235#issuecomment-1927184068 If we receive a valid block that passes the anti-DoS threshold but doesn't advance the tip, the `BlockChecked` callback won't be called. This is because `ActivateBestChain` will return early since `pindexMostWork` is equal to `m_chain.Tip()`. Since the `BlockChecked` callback isn't called, `mapBlockSource` won't be removed from.

URL

https://github.com/bitcoin/bitcoin/issue/29410

Closed by

Notes

Attention of

Kill Factor (1-10)

Save

Back to List