Issue Details

Number

17020

Title

contrib: makeseeds.py improvements

Description

Some suggestions for improvements, or at least for discussion between major releases: - [x] Read [suspicious hosts](https://github.com/bitcoin/bitcoin/pull/16999#issuecomment-536869449) from a file (done in #17823, removed completely in #24862) - [x] [Determinism](https://github.com/bitcoin/bitcoin/pull/16999#issuecomment-537070141) could be improved (this is useful for cross-checking) - [x] Read ASNs from a file (Done in #24864) - [x] Per-ASN limit [isn't consistently enforced?](https://github.com/bitcoin/bitcoin/pull/16999#issuecomment-537173086) - [x] [A max of 2 seeds per ASN seems a bit strict](https://github.com/bitcoin/bitcoin/pull/16999#issuecomment-536999544) at lest for IPv6 (done in #24818) - [x] [Should we bump MIN_BLOCKS?](https://github.com/bitcoin/bitcoin/pull/16999#issuecomment-536999544) (done in #24818) - [x] Some [typos](https://github.com/bitcoin/bitcoin/pull/16999#pullrequestreview-295794240) in the comments - [x] Handle and hardcode TorV3 peers (after #19954), see #20239 - [ ] Bring back onion functionality past TorV3 switch - [ ] We need a source of non-hardcoded V3 peers, currently the only ones are hardcoded and the seeder hasn't been updated to crawl v3 nodes yet (see sipa/bitcoin-seeder#92) - [ ] Consider increasing uptime requirements for Tor nodes from 10% as there [appear to be enough](#issuecomment-718622693) #7398 was a previous attempt to improve this script, but was abandoned, maybe some changes are useful.

URL

https://github.com/bitcoin/bitcoin/issue/17020

Closed by

Notes

Attention of

Kill Factor (1-10)

Save

Back to List