Issue Details

Number

17508

Title

Simpler settings interpretation

Description

Settings code cleanup in #15934 uncovered some surprising ways settings are being interpreted. Most or all of unexpected behaviors should be possible to simplify in some followup changes, and this issue tracks the followups: | Bug | Fix | Notes | - | - | - | | [Ignored network-qualified arguments](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/system.cpp#L334-L337) | #17482 | [Release notes (Command line)](https://github.com/ryanofsky/bitcoin/blob/pr/wdqual/doc/release-notes.md#command-line) [Ignored chain arguments](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/settings.cpp#L73-L78) | _tbd_ [Reversed config precedence](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/settings.cpp#L66-L71) | #17581 | [Release notes (Configuration file)](https://github.com/ryanofsky/bitcoin/blob/pr/wdmult/doc/release-notes.md#configuration-file). PR depends on #17493 to disallow multiple config assignments, which depends #17556 to fix a fragile python test and #17580 to apply `ALLOW_LIST` flags, which depends on #16545 to implement `ALLOW_LIST` flags [Misapplied default section config values](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/settings.cpp#L60-L63) | _tbd_ [Zombie config values](https://github.com/bitcoin/bitcoin/blob/397c6d32c8f8a20a3605ef0d51d159adc21fd125/src/util/settings.cpp#L107-L114) | _tbd_

URL

https://github.com/bitcoin/bitcoin/issue/17508

Closed by

Notes

Attention of

Kill Factor (1-10)

Save

Back to List