Issue Details
- Number
- 19732
- Title
- qa: Functional tests are intrinsic vulnerable to timeouts
- Description
- On master (3ab2582c7fe76d2839ab493512758d5601903c86) with this patch:
```diff
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -2868,7 +2868,7 @@ int64_t CConnman::PoissonNextSendInbound(int64_t now, int average_interval_secon
int64_t PoissonNextSend(int64_t now, int average_interval_seconds)
{
- return now + (int64_t)(log1p(GetRand(1ULL << 48) * -0.0000000000000035527136788 /* -1/2^48 */) * average_interval_seconds * -1000000.0 + 0.5);
+ return now + (int64_t)(log1p(((1ULL << 48) - 1) * -0.0000000000000035527136788 /* -1/2^48 */) * average_interval_seconds * -1000000.0 + 0.5);
}
CSipHasher CConnman::GetDeterministicRandomizer(uint64_t id) const
```
a bunch of functional tests fail due to the timeout:
```
feature_notifications.py | ✖ Failed | 62 s
interface_rest.py | ✖ Failed | 63 s
interface_zmq.py | ✖ Failed | 64 s
mempool_persist.py | ✖ Failed | 62 s
mempool_unbroadcast.py | ✖ Failed | 32 s
p2p_blocksonly.py | ✖ Failed | 61 s
p2p_feefilter.py | ✖ Failed | 63 s
p2p_getaddr_caching.py | ✖ Failed | 62 s
p2p_permissions.py | ✖ Failed | 63 s
p2p_segwit.py | ✖ Failed | 69 s
p2p_tx_download.py | ✖ Failed | 75 s
rpc_deprecated.py | ✖ Failed | 62 s
rpc_psbt.py | ✖ Failed | 65 s
rpc_psbt.py --descriptors | ✖ Failed | 67 s
rpc_rawtransaction.py | ✖ Failed | 64 s
wallet_abandonconflict.py | ✖ Failed | 63 s
wallet_balance.py | ✖ Failed | 63 s
wallet_basic.py | ✖ Failed | 68 s
wallet_basic.py --descriptors | ✖ Failed | 72 s
wallet_bumpfee.py | ✖ Failed | 64 s
wallet_groups.py | ✖ Failed | 62 s
wallet_implicitsegwit.py | ✖ Failed | 62 s
wallet_listreceivedby.py | ✖ Failed | 62 s
wallet_listtransactions.py | ✖ Failed | 62 s
wallet_resendwallettransactions.py | ✖ Failed | 62 s
```
Just bumping timeout values only decreases the probability of a new timeout failure occurrence.
Suggested solution #19588 was ugly and controversial, and it has being closed for now.
Related issues:
- #18832
- #18969
- #19265
- #19311
- #19711
- URL
-
https://github.com/bitcoin/bitcoin/issue/19732
- Closed by
-
Back to List